Fixing crashes on start; fixed special key signal handling post prior fixes

README.md

@@ -5,12 +5,11 @@ An onscreen keyboard for the mouse.
 * PyGObject
 * python-xlib
 * pyautogui
+* setproctitle
 * fast-autocomplete[levenshtein]
 
-# TODO
-<li>Get save and execute of custom commands working.</li>
-
 # Images
 ![1 image of the alphabet. ](images/pic1.png)
 ![2 Image of the symbols. ](images/pic2.png)
-![3 Image of the emoji. ](images/pic3.png)
+![3 Image of list of commands. ](images/pic3.png)
+![4 Image of the emoji. ](images/pic4.png)

requirements.txt

@@ -1,4 +1,5 @@
 PyGObject
-pyautogui
 python-xlib
-setproctitle
+pyautogui
+setproctitle
+fast-autocomplete[levenshtein]

src/__builtins__.py

@@ -34,9 +34,9 @@ class MissingConfigError(Exception):
 
 class Pyautogui_Controller(ControlMixin):
     def __init__(self):
-        self.isCtrlOn       = False
+        self.isCtrlOn  = False
-        self.isShiftOn      = False
+        self.isShiftOn = False
-        self.isAltOn        = False
+        self.isAltOn   = False
 
 
 
@@ -57,7 +57,7 @@ keys_json = {
         },
         "row4": {
             "pKeys": ['z', 'x', 'c', 'v', 'b', 'n', 'm', ',', '.', '?'],
-            "sKeys": ['', '', '<', '>', '[', ']', '(', ')', '{', '}']
+            "sKeys": ['', '', '<|shift+,', '>', '[', ']', '(', ')', '{', '}']
         },
     }
 }

src/core/columns/keys_column.py

@@ -54,9 +54,9 @@ class Keys_Column(Gtk.Box):
             row_box = self.add_row()
             if len(pKeys) == len(sKeys):
                 for i in range(10):
-                    pkey = pKeys[i]
+                    pKey = pKeys[i]
                     sKey = sKeys[i]
-                    row_box.add(Key(pkey, sKey))
+                    row_box.add(Key(pKey, sKey))
             else:
                 raise KeyboardRowMatchError("A row in keys_json has missmatched pKeys to sKeys lengths.")
 

src/core/widgets/defined_keys.py

@@ -17,20 +17,21 @@ class Esc_Key(Key):
     def __init__(self):
         super(Esc_Key, self).__init__("Esc", "Esc", iscontrol = True)
 
-    def setup_signals(self):
+    def _setup_signals(self):
-        self.connect("released", self._do_press_special_key)
+        self.connect("button-press-event", self._do_press_special_key)
+        self.connect("button-release-event", self._do_release_special_key)
 
 class CAPS_Key(Key):
     def __init__(self):
         super(CAPS_Key, self).__init__("Caps", "Caps", iscontrol = True)
 
-        self.setup_styling()
+        self._setup_styling()
-        self.show_all()
 
-    def setup_styling(self):
+    def _setup_styling(self):
         self.set_vexpand(True)
+        super()._setup_styling()
 
-    def setup_signals(self):
+    def _setup_signals(self):
         self.connect("released", self._clicked)
 
     def _clicked(self, widget = None):
@@ -45,11 +46,9 @@ class Backspace_Key(Key):
     def __init__(self):
         super(Backspace_Key, self).__init__("Backspace", "Backspace", iscontrol=True)
 
-    def setup_signals(self):
+    def _setup_signals(self):
-        self.connect("released", self._clicked)
+        self.connect("button-press-event", self._do_press_special_key)
-
+        self.connect("button-release-event", self._do_release_special_key)
-    def _clicked(self, widget = None):
-        typwriter.press_special_keys(self.get_label())
 
 class Emoji_Key(Key):
     def __init__(self, emoji_popover):
@@ -58,7 +57,7 @@ class Emoji_Key(Key):
         self._ctx           = self.get_style_context()
         self._emoji_popover = emoji_popover
 
-    def setup_signals(self):
+    def _setup_signals(self):
         self.connect("released", self._clicked)
 
     def _clicked(self, widget = None):
@@ -73,7 +72,7 @@ class Symbols_Key(Key):
         super(Symbols_Key, self).__init__("Symbols", "Symbols", iscontrol = True)
         self.setup_custom_signals()
 
-    def setup_signals(self):
+    def _setup_signals(self):
         self.connect("released", self._clicked)
 
     def setup_custom_signals(self):
@@ -92,30 +91,26 @@ class Symbols_Key(Key):
 class Enter_Key(Key):
     def __init__(self):
         super(Enter_Key, self).__init__("Enter", "Enter", iscontrol=True)
-        self.setup_styling()
+        self._setup_styling()
 
-    def setup_styling(self):
+    def _setup_styling(self):
         self.set_vexpand(True)
+        super()._setup_styling()
 
-    def setup_signals(self):
+    def _setup_signals(self):
-        self.connect("released", self._do_press_special_key)
+        self.connect("button-press-event", self._do_press_special_key)
+        self.connect("button-release-event", self._do_release_special_key)
 
 
 #############################  Bottom_Key_Row Keys  #############################
 
-class Esc_Key(Key):
-    def __init__(self):
-        super(Esc_Key, self).__init__("Esc", "Esc", iscontrol=True)
-
-    def setup_signals(self):
-        self.connect("released", self._do_press_special_key)
-
 class Space_Key(Key):
     def __init__(self):
         super(Space_Key, self).__init__("Space", "Space", iscontrol=True)
 
-    def setup_signals(self):
+    def _setup_signals(self):
-        self.connect("released", self._do_press_special_key)
+        self.connect("button-press-event", self._do_press_special_key)
+        self.connect("button-release-event", self._do_release_special_key)
 
 class AT_Key(Key):
     def __init__(self):
@@ -132,68 +127,78 @@ class Tab_Key(Key):
     def __init__(self):
         super(Tab_Key, self).__init__("Tab", "Tab", iscontrol=True)
 
-    def setup_signals(self):
+    def _setup_signals(self):
-        self.connect("released", self._do_press_special_key)
+        self.connect("button-press-event", self._do_press_special_key)
+        self.connect("button-release-event", self._do_release_special_key)
 
 class Del_Key(Key):
     def __init__(self):
         super(Del_Key, self).__init__("Del", "Del", iscontrol=True)
 
-    def setup_signals(self):
+    def _setup_signals(self):
-        self.connect("released", self._do_press_special_key)
+        self.connect("button-press-event", self._do_press_special_key)
+        self.connect("button-release-event", self._do_release_special_key)
 
 class Ctrl_Key(Key):
     def __init__(self):
         super(Ctrl_Key, self).__init__("Ctrl", "Ctrl", iscontrol=True)
 
-    def setup_signals(self):
+    def _setup_signals(self):
-        self.connect("released", self._do_press_special_key)
+        self.connect("button-press-event", self._do_press_special_key)
+        self.connect("button-release-event", self._do_release_special_key)
 
 class Shift_Key(Key):
     def __init__(self):
         super(Shift_Key, self).__init__("Shift", "Shift", iscontrol=True)
 
-    def setup_signals(self):
+    def _setup_signals(self):
-        self.connect("released", self._do_press_special_key)
+        self.connect("button-press-event", self._do_press_special_key)
+        self.connect("button-release-event", self._do_release_special_key)
 
 class Alt_Key(Key):
     def __init__(self):
         super(Alt_Key, self).__init__("Alt", "Alt", iscontrol=True)
 
-    def setup_signals(self):
+    def _setup_signals(self):
-        self.connect("released", self._do_press_special_key)
+        self.connect("button-press-event", self._do_press_special_key)
+        self.connect("button-release-event", self._do_release_special_key)
 
 class PrtSc_Key(Key):
     def __init__(self):
         super(PrtSc_Key, self).__init__("PrtSc", "PrtSc", iscontrol=True)
 
-    def setup_signals(self):
+    def _setup_signals(self):
-        self.connect("released", self._do_press_special_key)
+        self.connect("button-press-event", self._do_press_special_key)
+        self.connect("button-release-event", self._do_release_special_key)
 
 class Up_Key(Key):
     def __init__(self):
         super(Up_Key, self).__init__("Up", "Up", iscontrol=True)
 
-    def setup_signals(self):
+    def _setup_signals(self):
-        self.connect("released", self._do_press_special_key)
+        self.connect("button-press-event", self._do_press_special_key)
+        self.connect("button-release-event", self._do_release_special_key)
 
 class Down_Key(Key):
     def __init__(self):
         super(Down_Key, self).__init__("Down", "Down", iscontrol=True)
 
-    def setup_signals(self):
+    def _setup_signals(self):
-        self.connect("released", self._do_press_special_key)
+        self.connect("button-press-event", self._do_press_special_key)
+        self.connect("button-release-event", self._do_release_special_key)
 
 class Left_Key(Key):
     def __init__(self):
         super(Left_Key, self).__init__("Left", "Left", iscontrol=True)
 
-    def setup_signals(self):
+    def _setup_signals(self):
-        self.connect("released", self._do_press_special_key)
+        self.connect("button-press-event", self._do_press_special_key)
+        self.connect("button-release-event", self._do_release_special_key)
 
 class Right_Key(Key):
     def __init__(self):
         super(Right_Key, self).__init__("Right", "Right", iscontrol=True)
 
-    def setup_signals(self):
+    def _setup_signals(self):
-        self.connect("released", self._do_press_special_key)
+        self.connect("button-press-event", self._do_press_special_key)
+        self.connect("button-release-event", self._do_release_special_key)

src/core/widgets/emoji_popover.py

@@ -31,7 +31,6 @@ class Emoji_Notebook(Gtk.Notebook):
         self.set_current_page(0)
         self.set_scrollable(True)
 
-    @daemon_threaded
     def load_ui(self):
         emoji_data = None
         with open(EMOJI_FILE, 'r') as f:

src/core/widgets/key.py

@@ -4,50 +4,134 @@
 import gi
 gi.require_version('Gtk', '3.0')
 from gi.repository import Gtk
+from gi.repository import GLib
 
 # Application imports
 
 
 class Key(Gtk.Button or Gtk.ToggleButton):
-    def __init__(self, primary = "NULL", secondary = "NULL", iscontrol=False):
+    def __init__(self, primary = "NULL", secondary = "NULL", iscontrol = False):
         super(Key, self).__init__()
 
+        self.timer_id          = None
         self.iscontrol         = iscontrol
         self._primary_symbol   = primary
         self._secondary_symbol = secondary
+        self._alt_symbol       = ''
         self._is_upper         = False
         self._is_symbol        = False
         self._is_emoji         = False
+        self.isShiftOn         = False
 
+        self._setup_styling()
+        self._setup_signals()
+        self._subscribe_to_events()
+        self._setup_if_keycombo(secondary)
+
+
+    def _setup_styling(self):
         self.set_label(self._primary_symbol)
-        self.setup_custom_signals()
-        self.setup_signals()
 
-    def setup_custom_signals(self):
+    def _setup_signals(self):
+        self.connect("button-press-event", self._do_press)
+        self.connect("button-release-event", self._do_release)
+        self.connect("toggle-emoji-keys", self.toggle_emoji_keys)
+
+    def _subscribe_to_events(self):
         event_system.subscribe("toggle_caps", self.toggle_caps)
         event_system.subscribe("toggle_symbol_keys", self.toggle_symbol_keys)
 
-    def setup_signals(self):
+    def _setup_if_keycombo(self, secondary: str):
-        self.connect("released", self._do_type)
+        if not self.iscontrol and (len(secondary) > 1 and '|' in secondary):
-        self.connect("toggle-emoji-keys", self.toggle_emoji_keys)
+            self._secondary_symbol = secondary[0]
+
+            parts = secondary.split("|")[1].split("+")
+            for part in parts:
+                if "shift" == part.lower():
+                    self.isShiftOn = True
+
+            self._alt_symbol = parts[-1]
+
+
+    def _do_press(self, widget = None, eve = None):
+        if not self.timer_id:
+            self.did_loop_type = False
+            self.timer_id = GLib.timeout_add(500, self._do_wait_loop_type)
+
+
+    def _do_release(self, widget = None, eve = None):
+        if self.did_loop_type:
+            GLib.source_remove(self.timer_id)
+            self.timer_id      = None
+            self.did_loop_type = False
+            return
+
+        self._do_type()
+        GLib.source_remove(self.timer_id)
+        self.timer_id = None
+
+    def _do_wait_loop_type(self):
+        if not self.timer_id: return False
+        self.did_loop_type = True
+        self.timer_id = GLib.timeout_add(200, self._do_type)
+        return False
+
+    def _do_type(self):
+        if not self.timer_id: return False
 
-    def _do_type(self, widget = None):
         key = self.get_label().strip()
-        if not self._is_emoji:
+        if self._is_emoji:
-            typwriter.type(key)
-        else:
             typwriter.set_clipboard_data(key, "utf-16")
             typwriter.isCtrlOn = True
             typwriter.type('v')
             typwriter.isCtrlOn = False
 
-    def _do_press_special_key(self, widget = None):
+            return True
+
+        if self._alt_symbol and self._is_symbol:
+            typwriter.isShiftOn = self.isShiftOn
+            typwriter.type(self._alt_symbol)
+            typwriter.isShiftOn = False
+
+            return True
+
+        typwriter.type(key)
+        return True
+
+
+    def _do_press_special_key(self, widget = None, eve = None):
+        if not self.timer_id:
+            self.did_loop_type = False
+            self.timer_id = GLib.timeout_add(500, self._do_wait_loop_special_type)
+
+    def _do_release_special_key(self, widget = None, eve = None):
+        if self.did_loop_type:
+            GLib.source_remove(self.timer_id)
+            self.timer_id      = None
+            self.did_loop_type = False
+            return
+
+        self._do_type_special_key()
+        GLib.source_remove(self.timer_id)
+        self.timer_id = None
+
+    def _do_wait_loop_special_type(self):
+        if not self.timer_id: return False
+        self.did_loop_type = True
+        self.timer_id = GLib.timeout_add(200, self._do_type_special_key)
+        return False
+
+    def _do_type_special_key(self):
+        if not self.timer_id: return False
+
         key = self.get_label()
         if key in ["Ctrl", "Shift", "Alt"]:
-            ctx = widget.get_style_context()
+            ctx = self.get_style_context()
             ctx.remove_class("toggled_bttn") if ctx.has_class("toggled_bttn") else ctx.add_class("toggled_bttn")
 
         typwriter.press_special_keys(key)
+        return True
+
 
     def toggle_symbol_keys(self, widget = None, eve = None):
         if not self.iscontrol:
@@ -69,4 +153,4 @@ class Key(Gtk.Button or Gtk.ToggleButton):
         if not self.iscontrol:
             self._is_upper = not self._is_upper
             if not self._is_symbol:
-                self.set_label(self._primary_symbol.upper()) if self._is_upper else self.set_label(self._primary_symbol.lower())
+                self.set_label(self._primary_symbol.upper()) if self._is_upper else self.set_label(self._primary_symbol.lower())